You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
knn_merge_parts is used during brute force search if:
an offset index needs to be added to the indices. This feature is used in raft_ann_bench in the ground_truth generator. There is an easy workaround for this case.
Throw an error if input parameters are out of range
Ideally improve knn_merge_parts, so that it handles larger k.
Additional context
The limitation comes from the fact that we are using faiss::blockselect. We have radix top-k that does not have a limit on k, so we just need to map the input to a format that radix-topk can consume.
The text was updated successfully, but these errors were encountered:
Generating ANN bench ground truth is affected by bug #2171, when k>1024. This PR fixes the issue for the ground truth generation.
Authors:
- Tamas Bela Feher (https://github.com/tfeher)
Approvers:
- Corey J. Nolet (https://github.com/cjnolet)
URL: #2180
Describe the bug
knn_merge_parts
is only implemented for k<=1024, and it silently returns without doing any work for k>1024:raft/cpp/include/raft/neighbors/detail/knn_merge_parts.cuh
Lines 149 to 171 in eb6fdef
knn_merge_parts
is used during brute force search if:raft_ann_bench
in the ground_truth generator. There is an easy workaround for this case.Expected behavior
Additional context
The limitation comes from the fact that we are using
faiss::blockselect
. We have radix top-k that does not have a limit on k, so we just need to map the input to a format that radix-topk can consume.The text was updated successfully, but these errors were encountered: