From 4d0d4e846bf8bf133e2d16285c0ce73224ce3c98 Mon Sep 17 00:00:00 2001 From: Mickael Ide Date: Mon, 18 Nov 2024 08:27:05 -0800 Subject: [PATCH] Add issue number in code --- cpp/include/raft/sparse/solver/lanczos.cuh | 2 ++ cpp/test/sparse/solver/lanczos.cu | 1 + 2 files changed, 3 insertions(+) diff --git a/cpp/include/raft/sparse/solver/lanczos.cuh b/cpp/include/raft/sparse/solver/lanczos.cuh index de3cd8fd2a..fed31e6a9c 100644 --- a/cpp/include/raft/sparse/solver/lanczos.cuh +++ b/cpp/include/raft/sparse/solver/lanczos.cuh @@ -38,6 +38,7 @@ namespace raft::sparse::solver { * @param v0 Optional Initial lanczos vector * @param eigenvalues output eigenvalues * @param eigenvectors output eigenvectors + * @todo Add largest eigenvalues computation (issue #2483) * @return Zero if successful. Otherwise non-zero. */ template @@ -65,6 +66,7 @@ auto lanczos_compute_smallest_eigenvectors( * @param v0 Optional Initial lanczos vector * @param eigenvalues output eigenvalues * @param eigenvectors output eigenvectors + * @todo Add largest eigenvalues computation (issue #2483) * @return Zero if successful. Otherwise non-zero. */ template diff --git a/cpp/test/sparse/solver/lanczos.cu b/cpp/test/sparse/solver/lanczos.cu index 1768b1d240..74611a1fd8 100644 --- a/cpp/test/sparse/solver/lanczos.cu +++ b/cpp/test/sparse/solver/lanczos.cu @@ -313,6 +313,7 @@ class lanczos_tests : public ::testing::TestWithParam expected_eigenvalues; }; +// TODO: Find a way to generate and validate test data without hardcoding them (issue #2485) const std::vector> inputsf = { {2, 34,