Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links on pypi.org are broken #121

Open
dagardner-nv opened this issue Jan 3, 2025 · 1 comment · May be fixed by #122
Open

Links on pypi.org are broken #121

dagardner-nv opened this issue Jan 3, 2025 · 1 comment · May be fixed by #122
Labels
doc Improvements or additions to documentation

Comments

@dagardner-nv
Copy link

The anchor links are non-functional, and the links to the tests/examples directory goto a 404 (https://pypi.org/project/rapids-dependency-file-generator/tests/examples/)

@jameslamb jameslamb added the doc Improvements or additions to documentation label Jan 3, 2025
@jameslamb
Copy link
Member

Thanks for taking the time to open this @dagardner-nv . You're totally right... the README we have today was designed to be used locally and in the GitHub GUI, and all those broken links are not a great experience on the PyPI homepage for the project.

That's something we'd like to work on at some point across RAPIDS: rapidsai/build-planning#70

I think the right fix here would probably be a mix of the following:

  • move information intended for developers modifying the project (like the test link you mentioned) into CONTRIBUTING.md
  • remove the manually-created table-of-contents (with all those anchor links) or make it work on PyPI.org
    • GitHub has a built-in table-of-contents for README files in its GUI, so we could probably just remove the manual one
  • other editorial changes to make the README suitable for PyPI

I'd be happy to review a PR if you'd like to make one. Otherwise, we can leave this issue here to track the work and someone will pick it up when they have interest/time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation
Projects
None yet
2 participants