Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Improve performance of quadtree_point_in_polygon #1486

Open
mroeschke opened this issue Nov 20, 2024 · 1 comment
Open

[FEA]: Improve performance of quadtree_point_in_polygon #1486

mroeschke opened this issue Nov 20, 2024 · 1 comment
Labels
feature request New feature or request Python Related to Python code

Comments

@mroeschke
Copy link
Contributor

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

Medium

Please provide a clear description of problem you would like to solve.

After #934, quadtree_point_in_polygon experienced a slowdown due to the passed points being a GeoSeries, and the x/y points are generated by interleaving them in GeoColumnAccessor.xy and then slicing x/y back out.

The performance was slightly gained back in #1446, but a full solution to address the performance regression in #934 should avoid this packing and unpacking of x/y points.

Generally the solution could be:

  1. Walk back the API changes in Refactors bounding.py to accept GeoSeries Input #934
  2. Use/develop an iterator in C++ to to adapt an SoA column to two AoS iterators cc @trxcllnt

Describe any alternatives you have considered

No response

Additional context

No response

@harrism
Copy link
Member

harrism commented Nov 21, 2024

More detail in #1446 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request Python Related to Python code
Projects
Status: Todo
Development

No branches or pull requests

2 participants