Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve logging verbosity issue in dask umap doctest #6197

Open
vyasr opened this issue Dec 20, 2024 · 0 comments
Open

Resolve logging verbosity issue in dask umap doctest #6197

vyasr opened this issue Dec 20, 2024 · 0 comments

Comments

@vyasr
Copy link
Contributor

vyasr commented Dec 20, 2024

As part of #6162 I was able to get all of the logging infrastructure in cuml transferred over to the new rapids-logger. This was more challenging in cuml than in some other repos because of the fact that cuml's log levels are inverted relative to spdlog's, and with this change I had to rework cuml's Python internals to do some translation (with a ton of help from @wphicks). With this translation we should have seen no changes to public APIs, but we were unable to diagnose one particular case in the dask UMAP code. To get #6162 merge I went ahead and updated the docstring to manually turn off verbosity, but somewhere in there something is going wrong so ideally we will want to get that resolved before the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant