From 04aa50f6f81e5414c6a2299380da7d54464ab98c Mon Sep 17 00:00:00 2001 From: Seunghwa Kang Date: Tue, 19 Nov 2024 12:59:04 -0800 Subject: [PATCH 1/3] fix build error --- .../prims/detail/sample_and_compute_local_nbr_indices.cuh | 5 ----- 1 file changed, 5 deletions(-) diff --git a/cpp/src/prims/detail/sample_and_compute_local_nbr_indices.cuh b/cpp/src/prims/detail/sample_and_compute_local_nbr_indices.cuh index 5ebc3dc8ae..8cd3b91b26 100644 --- a/cpp/src/prims/detail/sample_and_compute_local_nbr_indices.cuh +++ b/cpp/src/prims/detail/sample_and_compute_local_nbr_indices.cuh @@ -597,8 +597,6 @@ rmm::device_uvector compute_uniform_sampling_index_without_replacement( raft::random::RngState& rng_state, size_t K) { - assert(cugraph::invalid_edge_id_v == cugraph::ops::graph::INVALID_ID); - edge_t mid_partition_degree_range_last = static_cast(K * 10); // tuning parameter assert(mid_partition_degree_range_last > K); size_t high_partition_oversampling_K = K * 2; // tuning parameter @@ -1568,9 +1566,6 @@ uniform_sample_and_compute_local_nbr_indices( bool with_replacement) { using edge_t = typename GraphViewType::edge_type; - - assert(cugraph::invalid_edge_id_v == cugraph::ops::graph::INVALID_ID); - using vertex_t = typename GraphViewType::vertex_type; using key_t = typename thrust::iterator_traits::value_type; From 350e2e7044585dd1ccd52cf184a8d24736ebd3e8 Mon Sep 17 00:00:00 2001 From: Seunghwa Kang Date: Tue, 19 Nov 2024 13:30:11 -0800 Subject: [PATCH 2/3] fix warnings --- cpp/src/sampling/neighbor_sampling_impl.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/src/sampling/neighbor_sampling_impl.hpp b/cpp/src/sampling/neighbor_sampling_impl.hpp index ccca71cdf2..ce580ea9b4 100644 --- a/cpp/src/sampling/neighbor_sampling_impl.hpp +++ b/cpp/src/sampling/neighbor_sampling_impl.hpp @@ -179,7 +179,7 @@ neighbor_sample_impl(raft::handle_t const& handle, ? (fan_out.size() / num_edge_types) : ((fan_out.size() / num_edge_types) + 1); - for (auto hop = 0; hop < num_hops; hop++) { + for (size_t hop = 0; hop < num_hops; ++hop) { for (auto edge_type_id = 0; edge_type_id < num_edge_types; edge_type_id++) { auto k_level = fan_out[(hop * num_edge_types) + edge_type_id]; rmm::device_uvector srcs(0, handle.get_stream()); From 9cce3148dec4305cbf7f662d5e131f9aa2a19430 Mon Sep 17 00:00:00 2001 From: Seunghwa Kang Date: Tue, 19 Nov 2024 18:06:17 -0800 Subject: [PATCH 3/3] clang-format --- cpp/src/prims/detail/sample_and_compute_local_nbr_indices.cuh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/src/prims/detail/sample_and_compute_local_nbr_indices.cuh b/cpp/src/prims/detail/sample_and_compute_local_nbr_indices.cuh index 8cd3b91b26..dd0da77851 100644 --- a/cpp/src/prims/detail/sample_and_compute_local_nbr_indices.cuh +++ b/cpp/src/prims/detail/sample_and_compute_local_nbr_indices.cuh @@ -1565,7 +1565,7 @@ uniform_sample_and_compute_local_nbr_indices( size_t K, bool with_replacement) { - using edge_t = typename GraphViewType::edge_type; + using edge_t = typename GraphViewType::edge_type; using vertex_t = typename GraphViewType::vertex_type; using key_t = typename thrust::iterator_traits::value_type;