Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: spelling of "HomogenousBulkSamplerDataset" #4087

Open
2 tasks done
MatthiasKohl opened this issue Jan 11, 2024 · 0 comments
Open
2 tasks done

[BUG]: spelling of "HomogenousBulkSamplerDataset" #4087

MatthiasKohl opened this issue Jan 11, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@MatthiasKohl
Copy link
Contributor

Version

24.02

Which installation method(s) does this occur on?

No response

Describe the bug.

Just noticed in this cugraph dgl benchmarking script that the spelling of the bulk sampler class is wrong: HomogenousBulkSamplerDataset should be HomogeneousBulkSamplerDataset

It would be great to create an alias an deprecate the wrong spelling.
I haven't checked whether this applies to other class names, but it could be good to look for this kind of spelling issues with a code editor that supports checking for spelling in interface names (such as python functions and classes given the normal case formatting), since those can take a while to update due to the breaking changes

Minimum reproducible example

No response

Relevant log output

No response

Environment details

No response

Other/Misc.

No response

Code of Conduct

  • I agree to follow cuGraph's Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@MatthiasKohl MatthiasKohl added ? - Needs Triage Need team to review and classify bug Something isn't working labels Jan 11, 2024
@BradReesWork BradReesWork removed the ? - Needs Triage Need team to review and classify label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants