From a3cda5de57e7c5849c85befd5b27ccea21b10255 Mon Sep 17 00:00:00 2001 From: Alex Barghi <105237337+alexbarghi-nv@users.noreply.github.com> Date: Mon, 6 Nov 2023 21:28:06 -0500 Subject: [PATCH] [BUG] Restore the original default order of CSR, which does not reverse edges in cuGraph-PyG (#3980) OGB and many other datasets express the edge index in CSR order, but in release 23.10, the default order was changed to CSC, which broke downstream workflows. This PR restores the original default, which should be acceptable for the most common datasets, and familiar to most PyG users. Closes #3969 Authors: - Alex Barghi (https://github.com/alexbarghi-nv) Approvers: - Tingyu Wang (https://github.com/tingyu66) - Rick Ratzel (https://github.com/rlratzel) URL: https://github.com/rapidsai/cugraph/pull/3980 --- python/cugraph-pyg/cugraph_pyg/data/cugraph_store.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/python/cugraph-pyg/cugraph_pyg/data/cugraph_store.py b/python/cugraph-pyg/cugraph_pyg/data/cugraph_store.py index 6192cd621d5..d1b24543956 100644 --- a/python/cugraph-pyg/cugraph_pyg/data/cugraph_store.py +++ b/python/cugraph-pyg/cugraph_pyg/data/cugraph_store.py @@ -214,7 +214,7 @@ def __init__( num_nodes_dict: Dict[str, int], *, multi_gpu: bool = False, - order: str = "CSC", + order: str = "CSR", ): """ Constructs a new CuGraphStore from the provided @@ -260,11 +260,11 @@ def __init__( Whether the store should be backed by a multi-GPU graph. Requires dask to have been set up. - order: str (Optional ["CSR", "CSC"], default = CSC) - The order to use for sampling. Should nearly always be CSC - unless there is a specific expectation of "reverse" sampling. - It is also not uncommon to use CSR order for correctness - testing, which some cuGraph-PyG tests do. + order: str (Optional ["CSR", "CSC"], default = CSR) + The order to use for sampling. CSR corresponds to the + standard OGB dataset order that is usually used in PyG. + CSC order constructs the same graph as CSR, but with + edges in the opposite direction. """ if None in G: