Revert "Fix empty cluster handling in tdigest merge (#16675)" #16800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5192b88.
jihoonson
force-pushed
the
revert-16675
branch
from
4fb48f9 to
fda9518
Compare
|
/ok to test |
abellina
approved these changes
Sep 11, 2024
|
@ttnghia @nvdbaranec fyi since you helped review the original change. Can you give it a look? |
|
Is the bug easy to fix? Can we just fix it instead of revert then fix? |
I haven't figure it out yet. I would prefer reverting the change and not letting the CI fail over the whole long weekend.. |
ttnghia
approved these changes
Sep 11, 2024
bdice
approved these changes
Sep 11, 2024
|
/ok to test |
|
/merge |
|
@jihoonson @ttnghia could we open an issue to track that there is still a bug that needs to be fixed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts #16675, which has introduced another bug. Our nightly CI pipeline is failing because of this bug (NVIDIA/spark-rapids#11463). I can reproduce the bug within a libcudf unit test. I will make another PR to fix both the original issue and the new bug.
Checklist