-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate dask-cudf README improvements to dask-cudf sphinx docs #16765
Merged
rapids-bot
merged 17 commits into
rapidsai:branch-24.10
from
rjzamora:dask-cudf-api-doc-update
Sep 16, 2024
Merged
Changes from 13 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
50bb40b
Small README updates
rjzamora 62bddeb
Merge remote-tracking branch 'upstream/branch-24.10' into dask-cudf-a…
rjzamora 9e46915
move most README updates into offical doc page
rjzamora 11181d8
roll back unnecessary change
rjzamora a26d0fa
grammar tweak
rjzamora 2319978
Merge remote-tracking branch 'upstream/branch-24.10' into dask-cudf-a…
rjzamora 6636989
move links closer to top of readme
rjzamora b5ce1b6
Merge branch 'branch-24.10' into dask-cudf-api-doc-update
rjzamora 22421a8
Merge branch 'branch-24.10' into dask-cudf-api-doc-update
rjzamora 3933bb3
Merge branch 'branch-24.10' into dask-cudf-api-doc-update
rjzamora ca2a3cf
Merge remote-tracking branch 'upstream/branch-24.10' into dask-cudf-a…
rjzamora c286ab5
fix note in 10min notebook
rjzamora 4b326cb
small improvements
rjzamora 4c41a51
update hyphenation in 10min
rjzamora 28c841e
address more code review
rjzamora 00048c6
add missing colon
rjzamora 58281ea
Merge branch 'branch-24.10' into dask-cudf-api-doc-update
rjzamora File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these changes actually format it correctly when viewing the notebook? This is a markdown cell, shouldn't it be formatted as markdown? This is a real question, I have no idea what it should look like and didn't check it myself to how that looks after the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I just made this change after seeing that the cell was "off" in my browser: https://docs.rapids.ai/api/cudf/24.10/user_guide/10min/
I had to do a bit of research to learn that you need to use html to make a note like this work in a jupyter notebook.