From 54b60de6bfc41667483ba0182effb0b4ea7df59c Mon Sep 17 00:00:00 2001 From: Matthew Murray Date: Fri, 30 Aug 2024 05:52:50 -0700 Subject: [PATCH 1/3] Remove xfail from torch-cudf.pandas integration test --- .../third_party_integration_tests/tests/test_pytorch.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/python/cudf/cudf_pandas_tests/third_party_integration_tests/tests/test_pytorch.py b/python/cudf/cudf_pandas_tests/third_party_integration_tests/tests/test_pytorch.py index ae9db3836a6..ad287471aa0 100644 --- a/python/cudf/cudf_pandas_tests/third_party_integration_tests/tests/test_pytorch.py +++ b/python/cudf/cudf_pandas_tests/third_party_integration_tests/tests/test_pytorch.py @@ -121,8 +121,6 @@ def test_torch_tensor_ctor(): return torch.tensor(s.values) -@pytest.mark.xfail_cudf_pandas(reason="Known failure, see xdf/#210") -@pytest.mark.xfail_compare def test_torch_tensor_from_numpy(): s = pd.Series(range(5)) return torch.from_numpy(s.values) From b083317ea1b8f433e963dff18717c8aea53bc29b Mon Sep 17 00:00:00 2001 From: Matthew Murray Date: Thu, 5 Sep 2024 08:11:51 -0700 Subject: [PATCH 2/3] add ci job --- .github/workflows/pr.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index 8730804e8b6..fe07b61d39e 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -36,6 +36,7 @@ jobs: - unit-tests-cudf-pandas - pandas-tests - pandas-tests-diff + - third-party-integration-tests-cudf-pandas secrets: inherit uses: rapidsai/shared-workflows/.github/workflows/pr-builder.yaml@branch-24.10 if: always() @@ -304,3 +305,14 @@ jobs: node_type: cpu4 build_type: pull-request run_script: "ci/cudf_pandas_scripts/pandas-tests/diff.sh" + third-party-integration-tests-cudf-pandas: + needs: wheel-build-cudf + secrets: inherit + uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@branch-24.10 + with: + build_type: pull-request + node_type: "gpu-v100-latest-1" + arch: "amd64" + container_image: "rapidsai/ci-conda:latest" + run_script: | + ci/cudf_pandas_scripts/third-party-integration/test.sh python/cudf/cudf_pandas_tests/third_party_integration_tests/dependencies.yaml From 6ed5c18ff055a91f385fe7c6d455da1c243fc336 Mon Sep 17 00:00:00 2001 From: Matthew Murray Date: Thu, 5 Sep 2024 11:23:06 -0700 Subject: [PATCH 3/3] clean up --- .github/workflows/pr.yaml | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index fe07b61d39e..8730804e8b6 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -36,7 +36,6 @@ jobs: - unit-tests-cudf-pandas - pandas-tests - pandas-tests-diff - - third-party-integration-tests-cudf-pandas secrets: inherit uses: rapidsai/shared-workflows/.github/workflows/pr-builder.yaml@branch-24.10 if: always() @@ -305,14 +304,3 @@ jobs: node_type: cpu4 build_type: pull-request run_script: "ci/cudf_pandas_scripts/pandas-tests/diff.sh" - third-party-integration-tests-cudf-pandas: - needs: wheel-build-cudf - secrets: inherit - uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@branch-24.10 - with: - build_type: pull-request - node_type: "gpu-v100-latest-1" - arch: "amd64" - container_image: "rapidsai/ci-conda:latest" - run_script: | - ci/cudf_pandas_scripts/third-party-integration/test.sh python/cudf/cudf_pandas_tests/third_party_integration_tests/dependencies.yaml