From 8a290b817099babf4ba3c951714f33d2f9096449 Mon Sep 17 00:00:00 2001 From: Robert Maynard Date: Thu, 18 Jan 2024 13:57:01 -0500 Subject: [PATCH 1/3] Ensure we use cccl patch for CUDA kernel symbol visibility --- cpp/cmake/thirdparty/patches/cccl_override.json | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/cpp/cmake/thirdparty/patches/cccl_override.json b/cpp/cmake/thirdparty/patches/cccl_override.json index fa82bfb5421..68fc8979c46 100644 --- a/cpp/cmake/thirdparty/patches/cccl_override.json +++ b/cpp/cmake/thirdparty/patches/cccl_override.json @@ -8,6 +8,11 @@ "issue" : "CCCL installs header-search.cmake files in nondeterministic order and has a typo in checking target creation that leads to duplicates", "fixed_in" : "2.3" }, + { + "file" : "cccl/hide_kernels.diff", + "issue" : "Mark all cub and thrust kernels with hidden visibility [https://github.com/nvidia/cccl/pulls/443]", + "fixed_in" : "2.3" + }, { "file" : "cccl/revert_pr_211.diff", "issue" : "thrust::copy introduced a change in behavior that causes failures with cudaErrorInvalidValue.", From 7c291f7f4a07a79d23fd5528053c6f59027683b1 Mon Sep 17 00:00:00 2001 From: Robert Maynard Date: Wed, 17 Jan 2024 10:16:59 -0500 Subject: [PATCH 2/3] Add CI checks to verify we have no external CUDA kernels --- .github/workflows/pr.yaml | 8 ++++++++ .github/workflows/test.yaml | 9 +++++++++ 2 files changed, 17 insertions(+) diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index edcc140b191..0e2c60e1c83 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -15,6 +15,7 @@ jobs: - checks - conda-cpp-build - conda-cpp-tests + - conda-cpp-checks - conda-python-build - conda-python-cudf-tests - conda-python-other-tests @@ -49,6 +50,13 @@ jobs: uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-tests.yaml@branch-24.02 with: build_type: pull-request + conda-cpp-checks: + needs: conda-cpp-build + secrets: inherit + uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-post-build-checks.yaml@branch-24.02 + with: + build_type: pull-request + enable_check_symbols: true conda-python-build: needs: conda-cpp-build secrets: inherit diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index df26a8c5916..7bb2530a7bc 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -14,6 +14,15 @@ on: type: string jobs: + conda-cpp-checks: + secrets: inherit + uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-post-build-checks.yaml@branch-24.02 + with: + build_type: nightly + branch: ${{ inputs.branch }} + date: ${{ inputs.date }} + sha: ${{ inputs.sha }} + enable_check_symbols: true conda-cpp-tests: secrets: inherit uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-tests.yaml@branch-24.02 From 5af43906c995b06b1fa5b823f5618a978dbe5808 Mon Sep 17 00:00:00 2001 From: Robert Maynard Date: Thu, 18 Jan 2024 20:05:08 -0500 Subject: [PATCH 3/3] Reorg sections based on feedback --- .github/workflows/pr.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index 0e2c60e1c83..43680ce458f 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -14,8 +14,8 @@ jobs: needs: - checks - conda-cpp-build - - conda-cpp-tests - conda-cpp-checks + - conda-cpp-tests - conda-python-build - conda-python-cudf-tests - conda-python-other-tests @@ -44,19 +44,19 @@ jobs: uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-build.yaml@branch-24.02 with: build_type: pull-request - conda-cpp-tests: + conda-cpp-checks: needs: conda-cpp-build secrets: inherit - uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-tests.yaml@branch-24.02 + uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-post-build-checks.yaml@branch-24.02 with: build_type: pull-request - conda-cpp-checks: + enable_check_symbols: true + conda-cpp-tests: needs: conda-cpp-build secrets: inherit - uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-post-build-checks.yaml@branch-24.02 + uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-tests.yaml@branch-24.02 with: build_type: pull-request - enable_check_symbols: true conda-python-build: needs: conda-cpp-build secrets: inherit