You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In this PR #15665 we added a function config_default_host_memory_resource that takes in parameters that allow us to disable the default pinned behavior in cuDF.
I tested this manually and neglected to run the unit tests in spark. The unit tests will, in the same process, re-initialize our plugin. Since all of the storage is static in this cuDF code around the pinned resource, we wind up calling config_default_host_memory_resource multiple times, causing the exception.
We'd like to propose a change and I can put up a bug fix for this today. Instead of a config_default_host_memory_resource, we'd like to pass the host_mr_options that were being passed here, directly to set_host_memory_resource. We'd also like set_host_memory_resource to not throw if called multiple times.
I think we can also remove the exception from make_host_mr and simplify that a bit.
I think this will unblock us and the api is cleaner: call set_host_memory_resource and pass the default options (which in our case are to always disable the default pool).
The text was updated successfully, but these errors were encountered:
In this PR #15665 we added a function
config_default_host_memory_resource
that takes in parameters that allow us to disable the default pinned behavior in cuDF.I tested this manually and neglected to run the unit tests in spark. The unit tests will, in the same process, re-initialize our plugin. Since all of the storage is static in this cuDF code around the pinned resource, we wind up calling
config_default_host_memory_resource
multiple times, causing the exception.We'd like to propose a change and I can put up a bug fix for this today. Instead of a
config_default_host_memory_resource
, we'd like to pass thehost_mr_options
that were being passed here, directly toset_host_memory_resource
. We'd also likeset_host_memory_resource
to not throw if called multiple times.Here is a high level change that I can try:
I think we can also remove the exception from
make_host_mr
and simplify that a bit.I think this will unblock us and the api is cleaner: call
set_host_memory_resource
and pass the default options (which in our case are to always disable the default pool).The text was updated successfully, but these errors were encountered: