Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Remove mr from test fixture once we require CUDA 12 #14236

Open
vyasr opened this issue Sep 28, 2023 · 0 comments
Open

[FEA] Remove mr from test fixture once we require CUDA 12 #14236

vyasr opened this issue Sep 28, 2023 · 0 comments
Labels
0 - Blocked Cannot progress due to external reasons feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.

Comments

@vyasr
Copy link
Contributor

vyasr commented Sep 28, 2023

Is your feature request related to a problem? Please describe.
The base fixture used by our gtests holds an mr for using in tests. However, this mr is just cudf's own default mr, so this mr doesn't serve much purpose.

Describe the solution you'd like
We should remove this mr from the fixture.

Additional context
The removal was attempted in #14075, but it uncovered what appears to be a compiler bug that only manifested on arm machines using CUDA 11. We were unable to determine exactly what caused the compiler error. Since the issue is specific to CUDA 11, the change can be made once we drop support for CUDA 11 and CUDA 12 becomes the minimum required version.

@vyasr vyasr added feature request New feature or request Needs Triage Need team to review and classify labels Sep 28, 2023
@GregoryKimball GregoryKimball added 0 - Blocked Cannot progress due to external reasons libcudf Affects libcudf (C++/CUDA) code. and removed Needs Triage Need team to review and classify labels Nov 9, 2023
@GregoryKimball GregoryKimball moved this to To be revisited in libcudf Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - Blocked Cannot progress due to external reasons feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
Status: To be revisited
Development

No branches or pull requests

2 participants