Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move cpp/src/hash/hash_allocator.cuh to include/cudf/hashing/detail directory #14143

Closed
davidwendt opened this issue Sep 20, 2023 · 0 comments · Fixed by #14163
Closed

Move cpp/src/hash/hash_allocator.cuh to include/cudf/hashing/detail directory #14143

davidwendt opened this issue Sep 20, 2023 · 0 comments · Fixed by #14163
Assignees
@davidwendt
Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.

Comments

@davidwendt
Copy link
Contributor

This subject header is used by several components outside of the cpp/src/hash directory including:

cpp/src/io/json/json_tree.cu
cpp/src/join/join_common_utils.hpp
cpp/src/stream_compaction/stream_compaction_common.hpp
cpp/src/text/subword/bpe_tokenizer.cuh

Reference: #13930 (comment)

This file should be moved/refactored to a more central location in the cpp/include directory
@davidwendt davidwendt added Needs Triage Need team to review and classify libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function labels Sep 20, 2023
@davidwendt davidwendt self-assigned this Sep 20, 2023
This was referenced Sep 20, 2023
Merged
Merged
rapids-bot bot pushed a commit that referenced this issue Sep 25, 2023
@davidwendt
Move cpp/src/hash/hash_allocator.cuh to include/cudf/hashing/detail (#…
3f47b5d 
…14163)

Moves `cpp/src/hash/hash_allocator.cuh` to `include/cudf/hashing/detail` so it may be more accessible from non-src/hash source files.  
Also, found `cpp/src/hash/helper_functions.hpp` used in the same way a moved that one as well.
No functional changes, just headers moved and includes fixed up.

Reference: #13930 (comment)

Closes #14143

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Yunsong Wang (https://github.com/PointKernel)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #14163
@bdice bdice removed the Needs Triage Need team to review and classify label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwendt davidwendt

Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move cpp/src/hash/hash_allocator.cuh to include/cudf/hashing/detail davidwendt/cudf
2 participants
@bdice @davidwendt