Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA][JNI] Add JNI bindings for cudf::strings::integers_to_hex() #14081

Closed
razajafri opened this issue Sep 11, 2023 · 4 comments · Fixed by #14205
Closed

[FEA][JNI] Add JNI bindings for cudf::strings::integers_to_hex() #14081

razajafri opened this issue Sep 11, 2023 · 4 comments · Fixed by #14205
Assignees
@razajafri
Labels
2 - In Progress Currently a work in progress feature request New feature or request Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS

Comments

@razajafri
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We need a way to convert a string col to a hex string col

Describe the solution you'd like
libcudf already supports this in convert_integers::integers_to_hex(). We should expose this method to Java

Describe alternatives you've considered
None
@razajafri razajafri added feature request New feature or request Needs Triage Need team to review and classify labels Sep 11, 2023
@razajafri razajafri self-assigned this Sep 11, 2023
@razajafri razajafri mentioned this issue Sep 12, 2023
Closed
@gerashegalov
Copy link
Contributor

you can reuse

https://github.com/NVIDIA/spark-rapids-jni/blob/ba6eefaf040a7eae1a4322d9ee5cff27a6fe65da/src/main/java/com/nvidia/spark/rapids/jni/CastStrings.java#L112

https://github.com/NVIDIA/spark-rapids-jni/blob/ba6eefaf040a7eae1a4322d9ee5cff27a6fe65da/src/main/cpp/src/CastStringJni.cpp#L211-L215

@razajafri
Copy link
Contributor Author

Thanks, let me confirm if that is what we want before closing this issue

@razajafri
Copy link
Contributor Author

I have confirmed, this works thanks @gerashegalov

@razajafri
Copy link
Contributor Author

Upon further investigation, the existing feature can't be used as is because it drops the leading zeros which are needed when converting binary data to string to be printed to the screen

@razajafri razajafri reopened this Sep 27, 2023
This was referenced Sep 27, 2023
Closed
Merged
@GregoryKimball GregoryKimball added 2 - In Progress Currently a work in progress Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS and removed Needs Triage Need team to review and classify labels Sep 27, 2023
rapids-bot bot pushed a commit that referenced this issue Sep 27, 2023
@razajafri
[Java] Add JNI bindings for integers_to_hex (#14205)
bff0fcd 
This PR adds a method to ColumnView class to allow for conversion from Integers to hex
closes #14081

Authors:
  - Raza Jafri (https://github.com/razajafri)

Approvers:
  - Kuhu Shukla (https://github.com/kuhushukla)
  - Robert (Bobby) Evans (https://github.com/revans2)

URL: #14205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@razajafri razajafri

Labels
2 - In Progress Currently a work in progress feature request New feature or request Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Java] Add JNI bindings for integers_to_hex razajafri/cudf
3 participants
@gerashegalov @razajafri @GregoryKimball