From d23b392c27df88192248fe9a417a0656d8cc103a Mon Sep 17 00:00:00 2001
From: Basit Ayantunde <rlamarrr@gmail.com>
Date: Thu, 19 Sep 2024 16:37:23 +0000
Subject: [PATCH] optimized build of cudf's tests

---
 cpp/tests/CMakeLists.txt                  | 13 +++++++------
 cpp/tests/{ => common}/cudf_test_impl.cpp |  0
 cpp/tests/{ => common}/cudf_test_impl.cu  |  0
 3 files changed, 7 insertions(+), 6 deletions(-)
 rename cpp/tests/{ => common}/cudf_test_impl.cpp (100%)
 rename cpp/tests/{ => common}/cudf_test_impl.cu (100%)

diff --git a/cpp/tests/CMakeLists.txt b/cpp/tests/CMakeLists.txt
index 6e5a565939b..af40b784ee9 100644
--- a/cpp/tests/CMakeLists.txt
+++ b/cpp/tests/CMakeLists.txt
@@ -20,6 +20,10 @@ enable_testing()
 include(rapids-test)
 rapids_test_init()
 
+add_library(cudftests_common OBJECT common/cudf_test_impl.cpp common/cudf_test_impl.cu)
+target_link_libraries(cudftests_common PUBLIC cudftestutil GTest::gtest GTest::gmock)
+target_compile_definitions(cudftests_common PUBLIC CUDF_TEST_EXCLUDE_GTEST=0)
+
 # This function takes in a test name and test source and handles setting all of the associated
 # properties and linking to build the test
 function(ConfigureTest CMAKE_TEST_NAME)
@@ -41,9 +45,7 @@ function(ConfigureTest CMAKE_TEST_NAME)
     set(_CUDF_TEST_STREAM_MODE cudf)
   endif()
 
-  add_executable(
-    ${CMAKE_TEST_NAME} ${_CUDF_TEST_UNPARSED_ARGUMENTS} cudf_test_impl.cu cudf_test_impl.cpp
-  )
+  add_executable(${CMAKE_TEST_NAME} ${_CUDF_TEST_UNPARSED_ARGUMENTS})
   set_target_properties(
     ${CMAKE_TEST_NAME}
     PROPERTIES RUNTIME_OUTPUT_DIRECTORY "$<BUILD_INTERFACE:${CUDF_BINARY_DIR}/gtests>"
@@ -58,10 +60,9 @@ function(ConfigureTest CMAKE_TEST_NAME)
 
   target_link_libraries(
     ${CMAKE_TEST_NAME}
-    PRIVATE cudftestutil GTest::gmock GTest::gmock_main GTest::gtest GTest::gtest_main
-            nvtx3::nvtx3-cpp $<TARGET_NAME_IF_EXISTS:conda_env> "${_CUDF_TEST_EXTRA_LIBS}"
+    PRIVATE cudftestutil cudftests_common GTest::gmock_main GTest::gtest_main nvtx3::nvtx3-cpp
+            $<TARGET_NAME_IF_EXISTS:conda_env> "${_CUDF_TEST_EXTRA_LIBS}"
   )
-  target_compile_definitions(${CMAKE_TEST_NAME} PRIVATE CUDF_TEST_EXCLUDE_GTEST=0)
   rapids_cuda_set_runtime(${CMAKE_TEST_NAME} USE_STATIC ${CUDA_STATIC_RUNTIME})
   rapids_test_add(
     NAME ${CMAKE_TEST_NAME}
diff --git a/cpp/tests/cudf_test_impl.cpp b/cpp/tests/common/cudf_test_impl.cpp
similarity index 100%
rename from cpp/tests/cudf_test_impl.cpp
rename to cpp/tests/common/cudf_test_impl.cpp
diff --git a/cpp/tests/cudf_test_impl.cu b/cpp/tests/common/cudf_test_impl.cu
similarity index 100%
rename from cpp/tests/cudf_test_impl.cu
rename to cpp/tests/common/cudf_test_impl.cu