From cc8c86857df92801561d2fa3311d8da85895ff33 Mon Sep 17 00:00:00 2001 From: Jason Lowe Date: Mon, 8 Jul 2024 16:54:45 -0500 Subject: [PATCH] Disable large string support for Java build (#16216) Disables libcudf large string support for the Java bindings build. The Java bindings need to be updated to handle large strings which is tracked by #16215. Closes #16199. Authors: - Jason Lowe (https://github.com/jlowe) Approvers: - Nghia Truong (https://github.com/ttnghia) URL: https://github.com/rapidsai/cudf/pull/16216 --- java/README.md | 10 +++++++--- java/ci/build-in-docker.sh | 3 ++- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/java/README.md b/java/README.md index 2d8e2190fee..0d9e060b7cd 100644 --- a/java/README.md +++ b/java/README.md @@ -51,9 +51,13 @@ CUDA 11.0: ## Build From Source Build [libcudf](../cpp) first, and make sure the JDK is installed and available. Specify -the cmake option `-DCUDF_USE_ARROW_STATIC=ON -DCUDF_ENABLE_ARROW_S3=OFF` when building so -that Apache Arrow is linked statically to libcudf, as this will help create a jar that -does not require Arrow and its dependencies to be available in the runtime environment. +the following cmake options to the libcudf build: +``` +-DCUDF_LARGE_STRINGS_DISABLED=ON -DCUDF_USE_ARROW_STATIC=ON -DCUDF_ENABLE_ARROW_S3=OFF +``` +These options: +- Disable large string support, see https://github.com/rapidsai/cudf/issues/16215 +- Statically link Arrow to libcudf to remove Arrow as a runtime dependency. After building libcudf, the Java bindings can be built via Maven, e.g.: ``` diff --git a/java/ci/build-in-docker.sh b/java/ci/build-in-docker.sh index 72b1742f7cb..5a429bdc739 100755 --- a/java/ci/build-in-docker.sh +++ b/java/ci/build-in-docker.sh @@ -1,7 +1,7 @@ #!/bin/bash # -# Copyright (c) 2020-2023, NVIDIA CORPORATION. All rights reserved. +# Copyright (c) 2020-2024, NVIDIA CORPORATION. All rights reserved. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. @@ -58,6 +58,7 @@ cmake .. -G"${CMAKE_GENERATOR}" \ -DCMAKE_INSTALL_PREFIX=$INSTALL_PREFIX \ -DCUDA_STATIC_RUNTIME=$ENABLE_CUDA_STATIC_RUNTIME \ -DUSE_NVTX=$ENABLE_NVTX \ + -DCUDF_LARGE_STRINGS_DISABLED=ON \ -DCUDF_USE_ARROW_STATIC=ON \ -DCUDF_ENABLE_ARROW_S3=OFF \ -DBUILD_TESTS=$BUILD_CPP_TESTS \