From 80dc0e5a596075e2a0fe00658e6a1fd66f61630e Mon Sep 17 00:00:00 2001
From: Vukasin Milovanovic <vmilovanovic@nvidia.com>
Date: Thu, 10 Oct 2024 15:21:05 -0700
Subject: [PATCH] code review

---
 cpp/include/cudf/detail/device_scalar.hpp | 2 ++
 cpp/src/join/distinct_hash_join.cu        | 1 -
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/cpp/include/cudf/detail/device_scalar.hpp b/cpp/include/cudf/detail/device_scalar.hpp
index 492ac6ce659..16ca06c6561 100644
--- a/cpp/include/cudf/detail/device_scalar.hpp
+++ b/cpp/include/cudf/detail/device_scalar.hpp
@@ -35,6 +35,8 @@ class device_scalar : public rmm::device_scalar<T> {
 #endif
   ~device_scalar() = default;
 
+// Implementation is the same as what compiler should generate
+// Could not use default move constructor as 11.8 compiler fails to generate it
 #ifdef __CUDACC__
 #pragma nv_exec_check_disable
 #endif
diff --git a/cpp/src/join/distinct_hash_join.cu b/cpp/src/join/distinct_hash_join.cu
index 562e9652bfd..515d28201e8 100644
--- a/cpp/src/join/distinct_hash_join.cu
+++ b/cpp/src/join/distinct_hash_join.cu
@@ -17,7 +17,6 @@
 #include "join_common_utils.hpp"
 
 #include <cudf/detail/cuco_helpers.hpp>
-#include <cudf/detail/device_scalar.hpp>
 #include <cudf/detail/distinct_hash_join.cuh>
 #include <cudf/detail/nvtx/ranges.hpp>
 #include <cudf/detail/utilities/cuda.cuh>