From 80a62bab36be2d14d587149e9dea4949fc97cd86 Mon Sep 17 00:00:00 2001 From: brandon-b-miller <53796099+brandon-b-miller@users.noreply.github.com> Date: Mon, 16 Sep 2024 08:45:44 -0500 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Bradley Dice Co-authored-by: Lawrence Mitchell --- cpp/include/cudf/datetime.hpp | 6 +++--- cpp/src/datetime/datetime_ops.cu | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cpp/include/cudf/datetime.hpp b/cpp/include/cudf/datetime.hpp index db406bb7ea8..e4f96db164b 100644 --- a/cpp/include/cudf/datetime.hpp +++ b/cpp/include/cudf/datetime.hpp @@ -40,7 +40,7 @@ namespace datetime { /** * @brief Types of datetime components that may be extracted. */ -enum class datetime_component { +enum class datetime_component : uint8_t { INVALID = 0, YEAR, MONTH, @@ -205,7 +205,7 @@ std::unique_ptr extract_nanosecond_fraction( rmm::device_async_resource_ref mr = rmm::mr::get_current_device_resource()); /** - * @brief Extracts the specified datetime component from any datetime type and + * @brief Extracts the specified datetime component from any datetime type and * returns an int16_t cudf::column. * * @param column cudf::column_view of the input datetime values @@ -218,7 +218,7 @@ std::unique_ptr extract_nanosecond_fraction( std::unique_ptr extract_datetime_component( cudf::column_view const& column, datetime_component component, - rmm::mr::device_memory_resource* mr = rmm::mr::get_current_device_resource()); + rmm::device_async_resource_ref mr = rmm::mr::get_current_device_resource()); /** @} */ // end of group /** diff --git a/cpp/src/datetime/datetime_ops.cu b/cpp/src/datetime/datetime_ops.cu index 49b4b9841fc..c8716dc8eb7 100644 --- a/cpp/src/datetime/datetime_ops.cu +++ b/cpp/src/datetime/datetime_ops.cu @@ -630,7 +630,7 @@ std::unique_ptr extract_second(column_view const& column, rmm::device_as std::unique_ptr extract_datetime_component(cudf::column_view const& column, datetime_component component, - rmm::mr::device_memory_resource* mr) + rmm::device_async_resource_ref mr) { CUDF_FUNC_RANGE(); switch (component) {