From 33de8d448ee2a48c80fe907c5b6609f0edd158a3 Mon Sep 17 00:00:00 2001 From: Vyas Ramasubramani Date: Tue, 19 Sep 2023 09:19:34 -0700 Subject: [PATCH] Some cleanup --- python/cudf/cudf/_lib/scalar.pxd | 3 +++ python/cudf/cudf/_lib/scalar.pyx | 4 ---- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/python/cudf/cudf/_lib/scalar.pxd b/python/cudf/cudf/_lib/scalar.pxd index ae1d350edc6..77733f59c3d 100644 --- a/python/cudf/cudf/_lib/scalar.pxd +++ b/python/cudf/cudf/_lib/scalar.pxd @@ -5,6 +5,9 @@ from libcpp.memory cimport unique_ptr from rmm._lib.memory_resource cimport DeviceMemoryResource +# TODO: Would like to remove this cimport, but it will require some more work +# to excise all C code in scalar.pyx that relies on using the C API of the +# pylibcudf Scalar underlying the DeviceScalar. from cudf._lib cimport pylibcudf from cudf._lib.cpp.scalar.scalar cimport scalar diff --git a/python/cudf/cudf/_lib/scalar.pyx b/python/cudf/cudf/_lib/scalar.pyx index 4dd217b6515..2717c361b98 100644 --- a/python/cudf/cudf/_lib/scalar.pyx +++ b/python/cudf/cudf/_lib/scalar.pyx @@ -166,10 +166,6 @@ cdef class DeviceScalar: _replace_nested(ret, lambda item: item is None, NA) return ret - # TODO: This is just here for testing and should be removed. - def get(self): - return self.c_value - @property def dtype(self): """