From 135d565670a447697f7d192c20d3e76fd1de6826 Mon Sep 17 00:00:00 2001 From: Muhammad Haseeb Date: Tue, 17 Sep 2024 17:53:28 +0000 Subject: [PATCH] Apply suggestions from code reviews. --- cpp/include/cudf/io/parquet.hpp | 2 +- cpp/src/io/parquet/writer_impl.cu | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/cpp/include/cudf/io/parquet.hpp b/cpp/include/cudf/io/parquet.hpp index 3d075005e52..ee03a382bec 100644 --- a/cpp/include/cudf/io/parquet.hpp +++ b/cpp/include/cudf/io/parquet.hpp @@ -39,7 +39,7 @@ namespace io { * @file */ -constexpr auto default_row_group_size_bytes = +constexpr size_t default_row_group_size_bytes = std::numeric_limits::max(); ///< Infinite bytes per row group constexpr size_type default_row_group_size_rows = 1'000'000; ///< 1 million rows per row group constexpr size_t default_max_page_size_bytes = 512 * 1024; ///< 512KB per page diff --git a/cpp/src/io/parquet/writer_impl.cu b/cpp/src/io/parquet/writer_impl.cu index 96a5f06d2b8..ec05f35d405 100644 --- a/cpp/src/io/parquet/writer_impl.cu +++ b/cpp/src/io/parquet/writer_impl.cu @@ -1825,7 +1825,8 @@ auto convert_table_to_parquet_data(table_input_metadata& table_meta, std::min(std::numeric_limits::max(), util::div_rounding_up_safe(max_row_group_size, avg_row_len)); // Safe comparison as rg_frag_size fits in size_type - max_page_fragment_size = std::min(rg_frag_size, max_page_fragment_size); + max_page_fragment_size = + std::min(static_cast(rg_frag_size), max_page_fragment_size); } // dividing page size by average row length will tend to overshoot the desired