Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CI doc builds to upload artifacts even when the build fails #76

Open
vyasr opened this issue Jun 28, 2024 · 1 comment
Open

Change CI doc builds to upload artifacts even when the build fails #76

vyasr opened this issue Jun 28, 2024 · 1 comment

Comments

@vyasr
Copy link
Contributor

vyasr commented Jun 28, 2024

Sphinx builds often fail in non-fatal ways. For example, the documentation may be produced with rendering issues. Diagnosing these issues in CI can be challenging because the produced documentation is not currently published unless the build succeeds. We should modify the doc build jobs to upload the documentation even if the build fails to make debugging easier. This can be done by adding set +e before the make html/sphinx-build invocation, saving the exit code, and triggering the upload before returning the resulting exit code.

rapids-bot bot pushed a commit to rapidsai/cudf that referenced this issue Dec 13, 2024
Contributes to #7795.

Also contributes to rapidsai/build-planning#76.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Yunsong Wang (https://github.com/PointKernel)
  - Bradley Dice (https://github.com/bdice)
  - David Wendt (https://github.com/davidwendt)

URL: #17545
@vyasr
Copy link
Contributor Author

vyasr commented Dec 13, 2024

A first example of this is done in rapidsai/cudf#17545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant