-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RAPIDS to mark all CUDA kernels with internal linkage #12
Comments
I think cuspatial also needs a task. |
Discussed with @robertmaynard - it'd be nice to check the entire RAPIDS Docker container to make sure we don't miss any libraries that exhibit this issue. |
Checked a couple boxes with merged PRs Do we have PRs for the remaining items? |
We still need PRs for cumlprims_mg and cuspatial. After that we need to follow-up with a docker container scan 'job'. |
Thanks Rob! 🙏 Noted this as "In progress". Please feel free to change if I've misunderstood |
Discussed in build infra sync, this is done. |
Downstream consumers of static built versions of RAPIDS C++ projects have encountered runtime issues due to multiple instances of the same kernel existing in different DSOs.
To resolve this issue we need to ensure that all CUDA kernels in all RAPIDS libraries need to be have internal linkage (
static
for projects using whole compilation,__attribute__((visibility("hidden")))
for header libraries / separable compilation ).My tasks
The text was updated successfully, but these errors were encountered: