Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RAPIDS to mark all CUDA kernels with internal linkage #12

Closed
8 tasks done
robertmaynard opened this issue Jan 11, 2024 · 6 comments
Closed
8 tasks done

Update RAPIDS to mark all CUDA kernels with internal linkage #12

robertmaynard opened this issue Jan 11, 2024 · 6 comments
Assignees
Labels

Comments

@robertmaynard
Copy link

robertmaynard commented Jan 11, 2024

Downstream consumers of static built versions of RAPIDS C++ projects have encountered runtime issues due to multiple instances of the same kernel existing in different DSOs.

To resolve this issue we need to ensure that all CUDA kernels in all RAPIDS libraries need to be have internal linkage ( static for projects using whole compilation, __attribute__((visibility("hidden"))) for header libraries / separable compilation ).

My tasks

Preview Give feedback
@harrism
Copy link
Member

harrism commented Jan 15, 2024

I think cuspatial also needs a task.

@bdice
Copy link
Contributor

bdice commented Jan 22, 2024

Discussed with @robertmaynard - it'd be nice to check the entire RAPIDS Docker container to make sure we don't miss any libraries that exhibit this issue.

@jakirkham jakirkham added the epic label May 21, 2024
@jakirkham
Copy link
Member

Checked a couple boxes with merged PRs

Do we have PRs for the remaining items?

@robertmaynard
Copy link
Author

Checked a couple boxes with merged PRs

Do we have PRs for the remaining items?

We still need PRs for cumlprims_mg and cuspatial. After that we need to follow-up with a docker container scan 'job'.
I updated cuml to be complete as they merged the PR

@jakirkham
Copy link
Member

Thanks Rob! 🙏

Noted this as "In progress". Please feel free to change if I've misunderstood

@sisodia1701
Copy link

Discussed in build infra sync, this is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants