-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmake>= 3.15 is missing dependency for wheel. #410
Comments
A couple small things I noticed:
It's completely unclear how removing the
Without the line it might fall back to the python version since it detects a system cmake. This would mean that it previously detected the system cmake as well. @henryiii do you have any idea what might go wrong here? |
Incorrect licenses and version fixed. Thanks for reporting. cmake(-native) isn't added to DEPENDS because it doesn't fix the error. |
Did you validate that that your patched version properly builds the package and doesn't just fall back to the pure Python version? |
ipk file extracted, and it's indeed Python only. |
Then the patch only prevented the correct overload from being chosen. Was the error message you did send initially all that was printed? Is there a way for you to increase the verbosity? Maybe that helps tracking the issue down. I would assume |
Regarding log. This is all unfortunately. |
Couple of thoughts: I notice you are inheriting from the CMake needs to be on the path. It's hard to tell if that's inherits or depends - it's a build-time dependency only. Is the output of Where do I find these recipes? Especially the "build-meta" ones. I found https://git.openembedded.org/openembedded-core/tree/meta/recipes-devtools/python/python3-flit-core_3.9.0.bb?h=scarthgap, though that inherits "pypi" and python-flit-core, so not sure where those are. EDIT: NumPy still uses the old setuptools build, sadly, that would have been an interesting recipe to compare to. The flit recipes use EDIT: Ah, found the inherit bits. https://git.openembedded.org/openembedded-core/tree/meta/classes-recipe/python_pep517.bbclass?h=scarthgap looks like the one you want. The flit-core one is doing a flit-core bootstrap build, which technically was only supposed to be used for bootstrapping minimal dependencies. |
When inherit python_pep517 instead of python_flit_core, results in an empty main package. |
Rapidfuzz is the only recipe which using scikit-build-core. |
Doesn't yocto use a vendor approach to packaging? Something similar to homebrew? I had some experience with yocto in the past, maybe I can help here. Could you point to the relevant branches containing |
A few things that I've gathered so far:
This is all I've managed to gather prior to setting up a yocto build and playing around with the actual definitions. @Hains if you have some contacts that could help with this process on the open-embedded side, it would be great to get together and see how to handle each one of these. Footnotes |
Create PR as a start (master branch). Not send yet. When ready, I'll send PR to OE. Edit: Noticed typo 'verison' . I'll fix that later. |
|
Yes, indeed. Thanks. |
The problem is triggered by 'inherit python3targetconfig' due to setup_target_config() With this patch
Rapidfuzz compiles files without any patch. Uncomment 'export _PYTHON_SYSCONFIGDATA_NAME' leads to error: File "/home/hains/openpli-dm920-python3/build/tmp/work/cortexa15hf-neon-vfpv4-oe-linux-gnueabi/rapidfuzz/3.10.0.+git/recipe-sysroot-native/usr/lib/python3.12/sysconfig.py", line 536, in _init_posix I can provide a more extended traceback when needed. Uncomment 'export PYTHONPATH=${STAGING_LIBDIR' leads to compile error: DEBUG: Executing shell function do_compile |
New PR (scikit-build-coe branch) |
I assume this was fixed and is now only waiting for openembedded/openembedded-core#99 to get merged. Right? |
Yes, it's up to OE now. |
Building Rapidfuzz with Yocto project., Scarthgap branch.
https://git.openembedded.org/openembedded-core/log/?h=scarthgap
I ported Rapidfuzz to the scikit-build-core build system in our build-environment
OpenPLi/openpli-oe-core@12b5e86
I need to apply a patch to remove the cmake check in the pyproject.toml file as workaround.
OpenPLi/openpli-oe-core@12b5e86#diff-938b3f5a03475ad51edd749573d6c87e01a6267ce468572141204948d80bc37fR12
To fix compile error:
Log data follows: | DEBUG: Executing shell function do_compile | * Getting build dependencies for wheel... | | ERROR Missing dependencies: | cmake>=3.15 | WARNING: exit code 1 from a shell command.
Cmake version 3.28.3 is used.
This is the only problem.
Do you know a proper solution to fix this?
The text was updated successfully, but these errors were encountered: