Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing --newline param #51

Open
valk8 opened this issue Aug 2, 2023 · 2 comments
Open

Missing --newline param #51

valk8 opened this issue Aug 2, 2023 · 2 comments

Comments

@valk8
Copy link

valk8 commented Aug 2, 2023

Hi! It seems that since LOG-15149 it's no longer possible to control newline param using Docker CLI. Could you please tell me if it was removed intentionally? Should we fork and build our own image? We seem to be missing only this param.

@sbialkowski-r7
Copy link
Contributor

hi Valentyn, it's been a while since that commit so wouldn't remember all details; and apologies for the late reply, we don't monitor these repos as much as we should.

But I can't find what was the purpose of the --newline param by scanning that old code, I'm assuming that's why I removed it, seemed to be a NOP; I'd be very surprised if I removed it without good reason.

Hopefully you solved the issue, but if not, if you could let me know what the --newline param did that you need it?

@valk8
Copy link
Author

valk8 commented Apr 15, 2024

Hi Szymon. Thanks for your reply. From my understanding, it was passed among other CLI params to docker-loghose, which then broke the log stream into new lines, see docker-loghose param list. We haven't forked it yet, still using the original one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants