Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Merged answers? #25

Open
cbizon opened this issue Sep 18, 2020 · 1 comment
Open

Merge Merged answers? #25

cbizon opened this issue Sep 18, 2020 · 1 comment

Comments

@cbizon
Copy link
Contributor

cbizon commented Sep 18, 2020

An example of this problem is running AC on strider_relay_mouse.json.txt (in the repo).

In graph coalesence, we merge N nodes and link that merged set to a common new node.

Sometimes the same N nodes link to multiple different new nodes. We return each of these new nodes as a new coalesced answer.

So if old1, old2 are both linked to new1, new2, we return 2 new answers, one with new1, one with new 2.

That was done primarily so that the rewritten query is simple (we add in one new query node). But it makes looking through the results suboptimal. Really, it would be better to combine n1 and n2 into a single answer. But now there are 2 new nodes in an answer.

Do we need to put 2 qnodes into the query? Can answers that only have one new node just not include a mapping to extra_qnode_2? Or can we leave just a single new qnode and have 2 mappings from one answer to that qnode?

@patrickkwang this gets into a TRAPI issue that I'm not sure the best way forward on.

@patrickkwang
Copy link

None of these options seems unreasonable. I think we just need to make sure the behavior is aligned with the user's expectations for how this operation works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants