Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle qrel binarization #7

Open
JMMackenzie opened this issue Nov 28, 2024 · 3 comments
Open

Handle qrel binarization #7

JMMackenzie opened this issue Nov 28, 2024 · 3 comments

Comments

@JMMackenzie
Copy link
Contributor

We should check how TREC handle qrel binarization and follow the same process, paying attention to types and trying to make things as clear as possible.

@mpetri
Copy link
Contributor

mpetri commented Dec 12, 2024

but RBP supports float gain values. do we need to do this?

@mpetri
Copy link
Contributor

mpetri commented Dec 12, 2024

actually right now it is a bit of a bug that we cast the value to int and if the max value is > 1 we don't normalize the metric to [0,1] (I guess the RBP paper also doesn't do this)

@JMMackenzie
Copy link
Contributor Author

JMMackenzie commented Dec 12, 2024

Yeah, we should check how to handle - I believe we should allow gain mapping to floats like you suggested, but we'd need to be explicit about it somehow. Perhaps just let the qrels reader handle floats?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants