Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Adam text patching #315

Open
MayberryZoom opened this issue May 6, 2024 · 2 comments · Fixed by #319
Open

Improve Adam text patching #315

MayberryZoom opened this issue May 6, 2024 · 2 comments · Fixed by #319
Labels
enhancement New feature or request

Comments

@MayberryZoom
Copy link
Contributor

The text field in each hint is only a string. If this was changed to a list (like with DNA hints), then hint text could span multiple pages. I think in theory this could support any number of pages, as long as new text IDs were added as necessary. This feature would probably only be useful for plando purposes, as rando should never exceed one page outside of DNA hints.

@MayberryZoom MayberryZoom added the enhancement New feature or request label May 6, 2024
@MayberryZoom
Copy link
Contributor Author

There is an unfortunate limitation in the game itself in regards to this, which is that each Adam station has a maximum number of pages (the same as the length of the vanilla conversation). If this length is exceeded, the final working page will be displayed again each time the text is advanced.

I have no idea exactly what decides this or how to fix it, but my assumption at this point is that it has something to do with voice lines. I've tried simply adding new voice lines following the same naming convention, but clearly they're defined somewhere in the game explicitly (though it's not on the actor data as far as I can see).

Swapping out the "conversation ID" (the key in tCaptionList for the array that contains the list of pages) also doesn't help as far as I can tell. I'll have to revisit this though, since the voice lines didn't update, so I'm thinking that maybe I did this wrong. Swapping out sInteractionLiteralID also might do something, but I think this is unrelated as it shares a value across different Adams.

This limitation isn't a high urgency issue, as this is something that's an advanced use case anyways, but this should still be fixed eventually. Especially since there are Adams with conversations only a few pages long. As such, I'm renaming this issue to reflect that.

@MayberryZoom MayberryZoom changed the title Non-DNA hint text can only be one page long Improve Adam text patching May 21, 2024
@MayberryZoom
Copy link
Contributor Author

I want to leave this issue open, since there's still the limitation of the page limits, which will hopefully be fixed eventually.

@MayberryZoom MayberryZoom reopened this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant