Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kubernetes recommended labels to rke2 static pods #7329

Open
vlaborie opened this issue Nov 22, 2024 · 0 comments
Open

Add Kubernetes recommended labels to rke2 static pods #7329

vlaborie opened this issue Nov 22, 2024 · 0 comments
Labels
kind/enhancement An improvement to existing functionality priority/low
Milestone

Comments

@vlaborie
Copy link

Is your feature request related to a problem? Please describe.

I use Kubernetes recommended labels, notably app.kubernetes.io/name to determine which app is running in pods and correctly monitoring it (i can group or filter logs/metrics by theses labels, add custom logs parsing and alerting if necessary).

Describe the solution you'd like

I like if rke2 deployed static pods (etcd, cloud-controller-manager, kube-apiserver, kube-controller-manager, kube-scheduler) have theses labels configured by default.

Describe alternatives you've considered

There is no fully automated way to do this, right now i need to add an hardcoded exception to label parsing for every project not having theses recommended labels (eg. parsing component label only for rke2 static pods) hopping for having no conflict with other projects labels.

@brandond brandond added this to the Backlog milestone Nov 22, 2024
@brandond brandond added kind/enhancement An improvement to existing functionality priority/low labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement An improvement to existing functionality priority/low
Projects
None yet
Development

No branches or pull requests

2 participants