Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner git history #2

Open
Kisty opened this issue Aug 24, 2018 · 2 comments
Open

Cleaner git history #2

Kisty opened this issue Aug 24, 2018 · 2 comments
Assignees

Comments

@Kisty
Copy link

Kisty commented Aug 24, 2018

Hi @ranaparamveer. Thanks for taking over this project. Really appreciate it!

I'm a bit concerned though with the history of changes. Having all the PRs rolled into the commit called Updated the build tools version and android sdk versions. doesn't explain in the message those changes. If I were you, I'd merge the PRs as single commits so that it looks a bit clearer. Also, the recent commits are duplicated and it looks a bit messy. Now changing git history once it's published is a bit messy but perhaps we could try and work together to make a cleaner history. Take a look at https://github.com/InflationX/Calligraphy/commits/master history. It's clear what the changes are and easier to read.

If you'd like, I can try and make the history a bit cleaner and see what you think. As I said, changing git history is hard but it's doable. Remember when you're committing code locally, you can change it as much as you like. But when you push changes to the server, you need to think twice about it. See http://justinhileman.info/article/git-pretty/git-pretty.png. Using git commit --amend can edit the last commit and other things you can do to clean up history before you push it.

I hope this helps and that you don't take it personally, it's just that I think we could do it better.

@ranaparamveer
Copy link
Owner

Thanks for pointing this out. I also agree with your concern. I'll definitely ask for your help once i start doing cleanup. Most probably i'll start with the process on coming weekend.

@ranaparamveer ranaparamveer self-assigned this Aug 29, 2018
@ranaparamveer
Copy link
Owner

Hi @Kisty,
Please let me know your availability in guiding me through cleanup process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants