Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(taskbar auto-hide when maximized) Add tolerance for window intersecting #1359

Open
whaaaley opened this issue Dec 17, 2024 · 3 comments
Open
Labels
info-needed Further information is requested mod-enhancement New feature or request for a mod

Comments

@whaaaley
Copy link

Windows often don't accurately report their sizes. When I use auto-hide when intersecting it often auto hides when I'm not close to the taskbar. Can there be a tolerance setting that gives some leeway before this it actually hides the bar?

@whaaaley whaaaley added the mod-enhancement New feature or request for a mod label Dec 17, 2024
@m417z
Copy link
Member

m417z commented Dec 18, 2024

If it's not even close, would a tolerance value help in this case? I'd rather fix the size detection if possible. How can I reproduce this problem?

@m417z m417z added the info-needed Further information is requested label Dec 18, 2024
@whaaaley
Copy link
Author

whaaaley commented Dec 18, 2024

Through trial and error, vscode is off by ~7px for me. A tolerance would help me at least, because I'm using GlazeWM. My windows are tiled, placed right at the edge of the taskbar. When I "fullscreen" an application, it's not a true maximize but it does take up the full size of the screen, overlapping the taskbar by a wider margin than the offset I'd apply. At this point I'd like to hide the taskbar.

I was going to take a recording of the behavior I'm seeing, but I think a recent windows update caused a compatibility issue with this mod. I'm getting [WH] [taskbar-auto-hide-when-maximized] [847:Wh_ModInit]: Unsupported Windows version when I turn on window intersection.

@m417z
Copy link
Member

m417z commented Dec 18, 2024

vscode is off by ~7px for me

I can't reproduce it. Is it only VSCode? I don't know how GlazeWM works, perhaps it causes all windows to have something like an invisible border.

When I "fullscreen" an application, it's not a true maximize but it does take up the full size of the screen, overlapping the taskbar by a wider margin than the offset I'd apply. At this point I'd like to hide the taskbar.

I'm not sure I follow. If it's overlapping the taskbar, it should hide as long as the default mode is used. A recording will help.

I'm getting [WH] [taskbar-auto-hide-when-maximized] [847:Wh_ModInit]: Unsupported Windows version

Post the full logs. This message can be shown for Windows older than Windows 10, but I assume that's not your case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info-needed Further information is requested mod-enhancement New feature or request for a mod
Projects
None yet
Development

No branches or pull requests

2 participants