Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is the color patch still needed? #398

Open
ralyodio opened this issue Feb 23, 2016 · 7 comments · May be fixed by #1350
Open

is the color patch still needed? #398

ralyodio opened this issue Feb 23, 2016 · 7 comments · May be fixed by #1350

Comments

@ralyodio
Copy link

I used to use this colorpatch-fix https://code.google.com/archive/p/trerront/downloads
with rtorrent-0.9.2 -- I'm wondering if the latest version still needs it and if this color patch will still work?

@chros73
Copy link
Contributor

chros73 commented Feb 23, 2016

You have to check it manually whether it's still can be applied.
But why don't you use rtorrent-ps by pyroscope? It includes way more UI enhancements. https://github.com/pyroscope/rtorrent-ps
Honestly, I don't understand why those patches haven't got merged into rtorrent project.

@rakshasa
Copy link
Owner

You think that is the only thing that could / needs to be merged?

I'm having enough trying to stay afloat in my day job, when I can I'll
return to this project.

On 24. feb. 2016, at 04:36, chros73 [email protected] wrote:

You have to check it manually whether it's still can be applied.
But why don't you use rtorrent-ps by pyroscope? It includes way more UI
enhancements. https://github.com/pyroscope/rtorrent-ps
Honestly, I don't understand why those patches haven't got merged into
rtorrent project.


Reply to this email directly or view it on GitHub
#398 (comment).

@chros73
Copy link
Contributor

chros73 commented Feb 26, 2016

I didn't want to be disrespectful with You at all, I know / I can imagine how it is.
I just wanted to point out (since lot of people doesn't even know about its existence, although it's available for years now) that those patches by pyroscope (especially the extended view) drastically change the way how we use rtorrent: we don't need any web interface / standalone GUI anymore to get the full potential of rtorrent.
I wish You the best and thank You for this amazing, highly customizable client!

@ralyodio
Copy link
Author

@chros73 i tried that rtorrent-ps once, could not figure out how to install it. Those instructions are very messy.

@rakshasa I applied the color-fix patch to the latest version of rtorrent, seems to work. Would be cool to have it merged into the official codebase, but I totally understand you've got more important things to do.

@ralyodio
Copy link
Author

any chance this got merged yet?

@vegged
Copy link

vegged commented Sep 29, 2024

any chance this got merged yet?

With the flurry of new activity in rtorrent, I'd love to second that question from 2018, as color support & rtorrent as a TUI program matter a lot to me! 🤗

@vegged
Copy link

vegged commented Sep 29, 2024

You think that is the only thing that could / needs to be merged?

I'm having enough trying to stay afloat in my day job, when I can I'll return to this project.

Welcome back, Jari! Is color support on the roadmap?

kannibalox added a commit to kannibalox/rtorrent that referenced this issue Dec 26, 2024
kannibalox added a commit to kannibalox/rtorrent that referenced this issue Dec 26, 2024
kannibalox added a commit to kannibalox/rtorrent that referenced this issue Dec 26, 2024
@kannibalox kannibalox linked a pull request Dec 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants