-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report multiple LICENSE files #78
Conversation
By default
Personally, this doesn't seem much worse than the status quo formatting wise, and also conveys all of the information. Not sure if people would actually use |
HTML:
Ideally these could be broken into a list using |
CSV:
We could customize this in |
@raimon49 Let me know if you have feedback/ideas on the direction of this. I really like how |
@johnthagen Thanks for the PR. First, I would like the base branch of PR to be release-3.0 instead of master. And it's better if the branch branch source is rebased to release-3.0.
Yes, I agree with you. This is a surprisingly good look.
Yes, this is indeed a bad look. Even though it's hard to replace
I think that if there is a single license file found, output it without enclosing it in
If you replace a valid option with For example, before pip-license 1.x to 2.x, the system warns to user if the deprecated option is specified. See sample implementation. Of course, the idea is to release 3.0 with the |
…amed --with-license-files argument
Done.
Done.
I implemented this for CSV class. Note that CSV still suffers from |
Ah, got it. I had rebased the fork via Git, but hadn't told GitHub to change the base for viewing purposes on GitHub. |
@raimon49 Checking in on this. Anything else you want to see before the 3.0.0 release? I noticed Python 3.9 comes out tomorrow. |
@johnthagen Thanks for the notification. I have taken this Pull Request and considered releasing version 3.0.0. But the scope of the changes is wide and some unit tests are broken. In particular, it conflicts with the tests added in #76. Your idea is great, but I'm releasing version 3.0.0 with no changes in the handling of the license file. |
@raimon49 Is handling multiple license files still something that can be considered? If so, do you know what approach you would accept? |
@johnthagen Handling multiple license files is an idea worth considering. The problem is that the current pip-licenses code and testing is vulnerable to major changes. I will attempt to resolve the problem when I have the time to do so. I may then cherry-pick some commits from your open Pull Request. |
Sounds great! When you get to it, if you'd like any more help shoot me a ping. |
I'm guessing this never got addressed? |
AFAIK not for now, as well as some other stuff from the version 4.0 list (which is not correctly updated and some stuff might be biased like a settings file for VS Code or environment caching benefits), although version 4.0 has been released over a year ago. |
Closes #71
Relates to 3.0.0 release #77
Open question: Should we change
--with-license-file
to--with-license-files
for added clarity?Unit tests will be updated once consensus is reached on the approach/design.
Tested against the
opencv-python-headless
package, which has two included LICENSE files.Supported: