New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change variable naming style in update_html_elements() #9

Open

naclomi opened this issue Mar 31, 2022 · 0 comments

naclomi commented Mar 31, 2022

In this method:

https://github.com/rafrisci/sports-book-manager/blob/master/sports_book_manager/book_scrape_class.py#L198

All-caps variable names tend to suggest globally scoped variables, usually that are constant in value. I'd suggest leaving them lowercase here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment