[Avatar] Support referrer policy in AvatarImage #2772
Merged
+99
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g12i
requested review from
benoitgrelard,
andy-hook,
vladmoroz and
lucasmotta
as code owners
|
Hi, |
chaance
approved these changes
Aug 16, 2024
|
@franckdsf I'm going to merge this as-is. Do you want to open a follow-up PR to address cross-origin issues? |
|
HI @chaance, sorry it's been ages since I opened that PR and I didn't notice your update! |
I've opened a pull request for that #3261 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include referrerPolicy when checking image in
useImageLoadingStatus(). Fixes: #1616In my case the issue occurred with Gmail avatars, served from
googleusercontent.com.I added tests which somehow simulate this behaviour. It's hard to add a storybook example without actually using my own image.