Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong focus when hotkey is an empty array #2491

Merged
merged 2 commits into from
Sep 26, 2024
Merged

fix: wrong focus when hotkey is an empty array #2491

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec1fe6a
fix: wrong focus when `hotkey` is an empty array
m-shaka Oct 29, 2023
251c5db
Merge branch 'main' into handle-an-empty-array
chaance Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react/toast/src/Toast.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,8 @@ const ToastViewport = React.forwardRef<ToastViewportElement, ToastViewportProps>
const handleKeyDown = (event: KeyboardEvent) => {
// we use `event.code` as it is consistent regardless of meta keys that were pressed.
// for example, `event.key` for `Control+Alt+t` is `†` and `t !== †`
const isHotkeyPressed = hotkey.every((key) => (event as any)[key] || event.code === key);
const isHotkeyPressed =
hotkey.length !== 0 && hotkey.every((key) => (event as any)[key] || event.code === key);
if (isHotkeyPressed) ref.current?.focus();
};
document.addEventListener('keydown', handleKeyDown);
Expand Down
Loading