Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hidden input for Switch does not render "over the button" #3235

Open
skonky opened this issue Nov 20, 2024 · 2 comments · May be fixed by #3250
Open

Hidden input for Switch does not render "over the button" #3235

skonky opened this issue Nov 20, 2024 · 2 comments · May be fixed by #3250

Comments

@skonky
Copy link

skonky commented Nov 20, 2024 •
edited
Loading

Bug report

Current Behavior

Screen.Recording.2024-11-20.at.13.07.56.mov

Also in the docs it seems not to be laid over the button
Screenshot 2024-11-20 at 13 32 16

Expected behavior

The hidden input is correctly rendered above the button without the consumer having to add relative position to the parent element

Reproducible example

Suggested solution

maybe wrap with a div that is relative

Additional context

Your environment

Software Name(s) Version
Radix Package(s) primitives 1.1.0
Radix Package(s) react-switch 1.1.1
React n/a 18
Browser Brave Version 1.73.89 Chromium: 131.0.6778.69 (Official Build) (arm64)
Assistive tech
Node n/a
npm/yarn
Operating System
@Brokyeom
Copy link

image

As per your suggestion, I tried wrapping the input with a div and confirmed that it is now positioned correctly over the button. Would it be alright if I create a PR to address this issue?

@Brokyeom Brokyeom linked a pull request Nov 24, 2024 that will close this issue
Open
@Brokyeom
Copy link

I made fix PR #3250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Switch] fix : Hidden input for Switch does not render "over the button" Brokyeom/primitives
2 participants
@skonky @Brokyeom