-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown renderer doesn't show content #33
Comments
It seems the issues is the link: |
Have run into the same issue. Also seems that html comments
as an error message on an otherwise empty, black page, with the browser developer console showing:
|
Thanks for filing this, I also noticed that using angle brackets in README urls etc prevents them from rendering and meant to file an issue. It's quite annoying since it's not easy to debug, even more so since there's no web-edit mechanism for readme (as you mention in #30 ) |
The markdown viewer is incredibly basic and relies heavily on the mdx and remark libraries -- it was intended to be a starting point to allow basic rendering of markdown files with the expectation that it will be improved with additional debugging and features later on. The source code for the markdown viewer is available in the Source Viewers Repository and we welcome any contributions there! |
I made pretty good experience with the commonmark js parser. But it might be a little limiting as it doesn't support tables for example. Anyway, could you fall back to just rendering the plain markdown in case of an error? An endless loading screen seems worse than just plain markdown, which is usually pretty human readable. |
Better error handling would be a great contribution. I'd welcome any pull requests which added this, otherwise this will have to wait a bit before I can implement it as the backlog is growing quicker than I can tackle issues. |
I've uploaded the following Markdown:
It doesn't render, Console shows:
The text was updated successfully, but these errors were encountered: