Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [AXIMST-688] Refactoring for the states #2521

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

ruzniaievdm
Copy link

@ruzniaievdm ruzniaievdm self-assigned this Mar 28, 2024
@ruzniaievdm ruzniaievdm changed the base branch from ts-develop-old to ts-develop March 28, 2024 17:53
@ruzniaievdm ruzniaievdm force-pushed the ruzniaievdm/feat/xblock-actions branch 2 times, most recently from 4531ee9 to c96c521 Compare March 28, 2024 18:10
@ruzniaievdm ruzniaievdm marked this pull request as ready for review March 28, 2024 18:41
@ruzniaievdm ruzniaievdm marked this pull request as draft March 28, 2024 18:41
@ruzniaievdm
Copy link
Author

ruzniaievdm commented Mar 29, 2024

@monteri please merge as separate commits

@ruzniaievdm ruzniaievdm marked this pull request as ready for review March 29, 2024 09:34
@ruzniaievdm ruzniaievdm requested a review from monteri March 29, 2024 09:34
@ruzniaievdm ruzniaievdm marked this pull request as draft March 29, 2024 10:38
@ruzniaievdm ruzniaievdm force-pushed the ruzniaievdm/feat/xblock-actions branch from 5446886 to 55b64c9 Compare March 29, 2024 11:44
@ruzniaievdm ruzniaievdm marked this pull request as ready for review March 29, 2024 11:45
@ruzniaievdm ruzniaievdm force-pushed the ruzniaievdm/feat/xblock-actions branch 2 times, most recently from 94bcb48 to 903db2c Compare March 29, 2024 13:43
is_course = xblock.scope_ids.usage_id.context_key.is_course
xblock_url = xblock_studio_url(xblock)
# Responsible for the ability to edit container xblock(copy, duplicate, move and manage access).
# It was used in the legacy and transferred here by simplifying it.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# It was used in the legacy and transferred here by simplifying it.
# It was used in the legacy and transferred here with simplification.
# After the investigation it was determined that the "show_other_action" condition below is sufficient to enable/disable actions on each xblock.

@ruzniaievdm ruzniaievdm force-pushed the ruzniaievdm/feat/xblock-actions branch from 903db2c to 50a1921 Compare March 29, 2024 15:08
@monteri monteri merged commit d8577f3 into ts-develop Mar 29, 2024
64 checks passed
monteri pushed a commit that referenced this pull request Mar 29, 2024
* feat: [AXIMST-688] Refactoring for the states

* fix: rebase artefacts
ruzniaievdm added a commit that referenced this pull request Apr 4, 2024
* feat: [AXIMST-688] Refactoring for the states

* fix: rebase artefacts
monteri pushed a commit that referenced this pull request Apr 10, 2024
* feat: [AXIMST-688] Refactoring for the states

* fix: rebase artefacts
GlugovGrGlib pushed a commit that referenced this pull request Apr 12, 2024
* feat: [AXIMST-688] Refactoring for the states

* fix: rebase artefacts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants