forked from openedx/edx-platform
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [AXIMST-688] Refactoring for the states #2521
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruzniaievdm
force-pushed
the
ruzniaievdm/feat/xblock-actions
branch
2 times, most recently
from
March 28, 2024 18:10
4531ee9
to
c96c521
Compare
@monteri please merge as separate commits |
ruzniaievdm
force-pushed
the
ruzniaievdm/feat/xblock-actions
branch
from
March 29, 2024 11:44
5446886
to
55b64c9
Compare
ruzniaievdm
force-pushed
the
ruzniaievdm/feat/xblock-actions
branch
2 times, most recently
from
March 29, 2024 13:43
94bcb48
to
903db2c
Compare
monteri
approved these changes
Mar 29, 2024
is_course = xblock.scope_ids.usage_id.context_key.is_course | ||
xblock_url = xblock_studio_url(xblock) | ||
# Responsible for the ability to edit container xblock(copy, duplicate, move and manage access). | ||
# It was used in the legacy and transferred here by simplifying it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
# It was used in the legacy and transferred here by simplifying it. | |
# It was used in the legacy and transferred here with simplification. | |
# After the investigation it was determined that the "show_other_action" condition below is sufficient to enable/disable actions on each xblock. |
ruzniaievdm
force-pushed
the
ruzniaievdm/feat/xblock-actions
branch
from
March 29, 2024 15:08
903db2c
to
50a1921
Compare
monteri
pushed a commit
that referenced
this pull request
Mar 29, 2024
* feat: [AXIMST-688] Refactoring for the states * fix: rebase artefacts
ruzniaievdm
added a commit
that referenced
this pull request
Apr 4, 2024
* feat: [AXIMST-688] Refactoring for the states * fix: rebase artefacts
monteri
pushed a commit
that referenced
this pull request
Apr 10, 2024
* feat: [AXIMST-688] Refactoring for the states * fix: rebase artefacts
GlugovGrGlib
pushed a commit
that referenced
this pull request
Apr 12, 2024
* feat: [AXIMST-688] Refactoring for the states * fix: rebase artefacts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring-for-the-states