feat: [AXIMST-676] Extend Sidenav endpoint with additional parameters #2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiedielnitsevIvan
force-pushed
the
Ivan_Niedielnitsev/AXIMST-676/feature/Extend-Sidenav-endpoint-with-additional-parameters
branch
from
2d65121 to
0af632a
Compare
monteri
reviewed
Mar 21, 2024
| @@ -43,6 +43,9 @@ def get_blocks(self, block): # pylint: disable=missing-function-docstring | |||
| description = block['special_exam_info'].get('short_description') | |||
| icon = block['special_exam_info'].get('suggested_icon', 'fa-pencil-square-o') | |||
|
|
|||
| if self.context.get('enable_prerequisite_block_type', False) and block.get('accessible') is False: | |||
There was a problem hiding this comment.
[question] is the a reason why we use is False instead of == False?
There was a problem hiding this comment.
In Python, False is a singleton object, meaning there is only one instance of it. Therefore, using is to check if a variable is False is both clearer and more efficient than using ==.
Here's the link to the Python documentation that supports this:
Python Documentation: The Python Language Reference - Boolean Operations
There was a problem hiding this comment.
Thank you for clarification!
|
Stylelint issue are required to be fixed |
monteri
pushed a commit
that referenced
this pull request
Mar 27, 2024
…#2516) * feat: [AXIMST-676] Extend Sidenav endpoint with additional parameters * test: [AXIMST-676] fix tests * refactor: [AXIMST-676] change block type to 'lock' if it has a prerequisite * style: [AXIMST-676] remove extra comma
ruzniaievdm
pushed a commit
that referenced
this pull request
Mar 28, 2024
…#2516) * feat: [AXIMST-676] Extend Sidenav endpoint with additional parameters * test: [AXIMST-676] fix tests * refactor: [AXIMST-676] change block type to 'lock' if it has a prerequisite * style: [AXIMST-676] remove extra comma
ruzniaievdm
pushed a commit
that referenced
this pull request
Apr 4, 2024
…#2516) * feat: [AXIMST-676] Extend Sidenav endpoint with additional parameters * test: [AXIMST-676] fix tests * refactor: [AXIMST-676] change block type to 'lock' if it has a prerequisite * style: [AXIMST-676] remove extra comma
monteri
pushed a commit
that referenced
this pull request
Apr 10, 2024
…#2516) * feat: [AXIMST-676] Extend Sidenav endpoint with additional parameters * test: [AXIMST-676] fix tests * refactor: [AXIMST-676] change block type to 'lock' if it has a prerequisite * style: [AXIMST-676] remove extra comma
GlugovGrGlib
pushed a commit
that referenced
this pull request
Apr 12, 2024
…#2516) * feat: [AXIMST-676] Extend Sidenav endpoint with additional parameters * test: [AXIMST-676] fix tests * refactor: [AXIMST-676] change block type to 'lock' if it has a prerequisite * style: [AXIMST-676] remove extra comma
monteri
pushed a commit
that referenced
this pull request
Apr 17, 2024
…#2516) * feat: [AXIMST-676] Extend Sidenav endpoint with additional parameters * test: [AXIMST-676] fix tests * refactor: [AXIMST-676] change block type to 'lock' if it has a prerequisite * style: [AXIMST-676] remove extra comma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: AXIMST-676 Extend Sidenav endpoint with additional parameters