Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make internal timestamp unit configurable #161

Open
kjnilsson opened this issue Jan 7, 2020 · 0 comments
Open

Make internal timestamp unit configurable #161

kjnilsson opened this issue Jan 7, 2020 · 0 comments

Comments

@kjnilsson
Copy link
Contributor

The timestamp that is captured is hard-coded to milliseconds which mean latency samples on very fast systems may be truncated to 0. Changing it directly to microseconds is a breaking change as the timestamp is passed to the ra_machine:apply/3 callback. Given this we could make it optionally overridable by providing an optional new ra_machine callback to get the current system time. E.g:

ra_machine:system_time()

We'd have to measure the potential performance impact of doing this for every command as well as every applied command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant