PUT /api/global-parameters/{name}

[awills96]

Is your feature request related to a problem? Please describe.

There is currently no functionality to modify global parameters using the Hop client.

Describe the solution you'd like

An implemented function in Client.java to make api PUT requests for global parameter values.

Describe alternatives you've considered

No response

Additional context

I saw that #62 has been open for vhost parameters, but there is no mention of global parameter setting in any other issue or discussion that I have seen (besides the latest version release which adds globals to Definitions.java).

I am able to make a contribution, but due to the existing related issue and the relative complexity of the solution, I wanted to check if there are any considerations from the maintainers of this project.

[michaelklishin]

It should be a matter of replicating the existing API for parameters without the virtual host argument. We'd appreciate a contribution :)

[awills96]

Thank you for the quick response, hopefully I'll have a contribution PR sometime next week or so.

[awills96]

A question for design,

Should the setter for global parameters be generic? I saw that in the case of upstreams and upstream sets, there is no generic function like setParameter(String component, ParameterizedTypeReference<List<T>> responseType) that is invoked unlike the getParameters function which has an existing implementation and use.

For my contribution, I also wanted to add in getting and setting mqtt_port_to_vhost_mapping, which follows a similar implementation to the way upstreams are handled. I have already worked in a getGlobalParameters(...) function based on existing API calls. Would a generic setGlobalParameters(...) be needed over lower level Mqtt calls that invoke this.httpLayer.put(...) directly (similar to Upstream declarations)?

[michaelklishin]

@awills96 we can use generics of it improves something… global parameter values really can be anything, so not a lot of room for additional type safety.

As for mqtt_port_to_vhost_mapping, it does not use any "MQTT calls", it is just a specific way of setting one specific parameter. It can be a separate method that relies on a more generic one, or it can use the HTTP API client directly, whichever option looks simpler overall.

[michaelklishin]

Addressed by @awills96 in #429. Thank you!

[acogoluegnes]

Addressed partly in #429 (support for mqtt_port_to_vhost_mapping, but not for any global parameter).