You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
this is a potentially surprising when features given to add_samplet in a different order -- even if feature and feature_names are paired correctly (@raamana -- a thing you warned me to check. good eye!)
Thanks a lot Will for putting pyradigm to test and reporting these bugs!
Let me look into them and see why they that happened. but these bugs hopefully haven't prevented you from running comparisons? I am zoom and we can discuss this more if you want -- and to prepare for the "progress report" so to say.
WillForan
added a commit
to WillForan/pyradigm
that referenced
this issue
Dec 11, 2020
Currently throws out anything that doesn't exactly match previous
feature names. A better solution might be to reorder features if
features_names are out of order. Also could make np.nan in features if
feature_names are missing
I had a few bugs (using wrong variable name), and realized I never got yelled at for providing bad feature names.
A few observations:
there can be too many (x, y, z and an additional "DNE" name)
or too few (only x, but have x, y, and z)
this is a potentially surprising when features given to
add_samplet
in a different order -- even iffeature
andfeature_names
are paired correctly (@raamana -- a thing you warned me to check. good eye!)The text was updated successfully, but these errors were encountered: