Fgb highlight fix #101
Open
Fgb highlight fix #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with highlighting behavior (mouseout) in addFgb by correctly restoring the original style using a deep copy of the
styleobject (withstructuredCloneand{ ...style }). Previously, only thecolorproperty was partially supported, and its behavior was incorrect. See FGB attach by group, highlightOptions, label as function #85 for an example app.Introduced the function
updateStyleFromPropertiesto update the highlighted style, if the relevant function argument is NULL and the data has a property with this name (e.g.:color,weight, etc..).Added some explanation to the @details section, outlining how to use direct styling arguments and feature-based styling from data properties. Addresses addFgb color depend on a variable? #87
I also simplified some
map$dependenciescalls and addedRoxygen: list(markdown = TRUE)do the Description. This helps with rendering the docs correctly.