Search for package dependencies in R code files #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But needs a small refectoring with the predicate matching.
Still not correct for quantified queries.
Predicates are still not correct.
It is only slightly faster, though.
Instead of re-creating it.
For predicates and quantification.
Parse each interesting call individually, faster and simpler than trying to match complicated calls.
- return end poisitions, we'll need it for markdown parsing - add markdown - add markdown_inline
TS uses the end position + 1 as the end position, translate that correctly to R, where we use the inclusive 1-based end position.
- filter out calls from the wrong package - add support for modules
gaborcsardi
force-pushed
the
feature/deps
branch
from
dcf4e37 to
b08b14b
Compare
gaborcsardi
force-pushed
the
feature/deps
branch
from
fcf64d6 to
146ddd2
Compare
52 tasks
Only an issue on older R, apparently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #390.