Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename no_tabs_linter() to whitespace_linter() #1954

Closed
MichaelChirico opened this issue Apr 7, 2023 · 0 comments · Fixed by #1955
Closed

Rename no_tabs_linter() to whitespace_linter() #1954

MichaelChirico opened this issue Apr 7, 2023 · 0 comments · Fixed by #1955
Labels
breaking change ☠️ API change likely to affect existing code

Comments

@MichaelChirico
Copy link
Collaborator

Inspired by r-devel/rdevguide#133 -- I know base R has a lot of places where \t is used, so adding flexbility to the linter will help.

The new suggested name is also more stylistically similar to other linters in the suite.

This issue is just about renaming the linter, filing now to get in before the 3.1.0 "deadline" alongside the other renamings. Future issues will address extending flexibility. Not doing so here because it's not trivial -- setting \t as the desired whitespace probably just refers to initial indentation, with other spaces in the file still just . The current linter doesn't support this flexibility (it just looks for \t anywhere), so it's more of an investment to get there.

@MichaelChirico MichaelChirico added the breaking change ☠️ API change likely to affect existing code label Apr 7, 2023
@MichaelChirico MichaelChirico added this to the 3.1.0 milestone Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ☠️ API change likely to affect existing code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant