Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup-r action uses non-latest version of Rtools43 #734

Closed
yutannihilation opened this issue Jun 8, 2023 · 7 comments
Closed

setup-r action uses non-latest version of Rtools43 #734

yutannihilation opened this issue Jun 8, 2023 · 7 comments
Labels
bug an unexpected problem or unintended behavior

Comments

@yutannihilation
Copy link
Contributor

The latest release tag is "5550-5548", but it seems the actual version is 5448-5475, guessing from the commit message (maybe you failed to push your local commit when you created the latest release...?).

r-hub/rtools43@45306dc

Could you update the version? The context is that the latest release of Rust requires binutils 2.40 and our CI started to fail, and the latest Rtools43 contains binutils 2.40 so updating Rtools should fix the problem. For more details, please refer to rust-lang/rust#112368 (comment).

@yutannihilation yutannihilation added the bug an unexpected problem or unintended behavior label Jun 8, 2023
@gaborcsardi
Copy link
Member

Can you show a failing build?

@gaborcsardi
Copy link
Member

IFAICT we have the latest version in the latest tag, based on the file sizes:
https://cran.r-project.org/bin/windows/Rtools/rtools43/files/
https://github.com/r-hub/rtools43/releases/tag/latest

@yutannihilation
Copy link
Contributor Author

Can you show a failing build?

https://github.com/extendr/rextendr/actions/runs/5178641957/jobs/9330392624#step:7:301

And if I updated Rtools by choco upgrade rtools, the build passes.

@yutannihilation
Copy link
Contributor Author

IFAICT we have the latest version in the latest tag, based on the file sizes:
https://cran.r-project.org/bin/windows/Rtools/rtools43/files/
https://github.com/r-hub/rtools43/releases/tag/latest

The last modified time of Rtools43 on CRAN is 2023-03-23 22:09, and the date of r-hub release is Jan 9th, so I thought it's not up-to-date.

@yutannihilation
Copy link
Contributor Author

I apologize. I found this is my terrible misunderstanding... The build I pointed above was on R 4.2 (so Rtools42), and I confirmed setup-r sets up the latest Rtools43 (in addition, windows runner already has the latest Rtools43 installed).

https://github.com/yutannihilation/r-lib-actions-issues-734/actions/runs/5209829439/jobs/9400160297#step:4:11

Sorry for the noise.

@gaborcsardi
Copy link
Member

No worries.

@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this issue

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants