Xhtml fixes #1
Open
Xhtml fixes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scape around the JavaScript includes.
* Inserting 'comment' tags to allow 'spans' to validate. * Modifying XSL output method to self-closing empty tags * Dropping 'small' tag, as it was causing CSS rule recursion * Adjusting SVG namespace * Creating new build
…Switching to Google CDN-hosted JQuery.
|
Hey, first of all, thanks for the input! The decision for using inline JQuery was made because we wanted the document formatting functioning even without an active internet connection. Do you have any suggestions how we could improve based on that principle? |
|
Yeah, that makes sense. I did try a variety of things to get it to validate using inline JS (including wrapping the CDATA sections in JS comments, see here: capncodewash@f05e9a8 ), however nothing seemed to allow it to validate. It seems that inline JavaScript is inherently breaky in XHTML. Is there any particular requirement for the stylesheet to generate XHTML, or would the HTML5 doctype be a possibility? |
|
Right now I can't think of anything against switching to HTML5 doctype. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
This branch contains a fixes to get the output from wsdl-viewer to validate as XHTML, and to fix some recursion issues I was having with the output.