Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add parse and parsefile functions #302

Merged
merged 1 commit into from
Dec 17, 2024
Merged

add parse and parsefile functions #302

merged 1 commit into from
Dec 17, 2024
+34 −17

Conversation

JeffBezanson
Copy link
Contributor

closes #272

@0x0f0f0f
Copy link

Can you export parsefile? (I guess parse clashes with Base.parse)

quinnj
quinnj approved these changes Dec 17, 2024
View reviewed changes
Copy link
Owner

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; will merge once CI finishes

@quinnj quinnj merged commit 737f6f4 into quinnj:main Dec 17, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnj quinnj quinnj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why JSON3.read is used both for file path and json string content, and blocks file after read?
3 participants
@JeffBezanson @0x0f0f0f @quinnj